Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the (unused) implementation of host_parse_nested_json #16135

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Remove the (unused) implementation of host_parse_nested_json #16135

merged 2 commits into from
Jul 2, 2024

Conversation

vuule
Copy link
Contributor

@vuule vuule commented Jun 28, 2024 •
edited by bdice
Loading

Description

Follow-up for #15537 and #15813 to remove some missed code.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vuule vuule added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 28, 2024
@vuule vuule self-assigned this Jun 28, 2024
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Jun 28, 2024
@vuule vuule marked this pull request as ready for review July 2, 2024 00:39
@vuule vuule requested a review from a team as a code owner July 2, 2024 00:39
@vuule vuule requested review from bdice and mythrocks July 2, 2024 00:39
@vuule
Copy link
Contributor Author

vuule commented Jul 2, 2024

/merge

@rapids-bot rapids-bot bot merged commit 04e3aa9 into rapidsai:branch-24.08 Jul 2, 2024
79 checks passed
@vuule vuule deleted the remove-host_parse_nested_json-impl branch July 2, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwendt davidwendt davidwendt approved these changes

@bdice bdice bdice approved these changes

@mythrocks mythrocks Awaiting requested review from mythrocks mythrocks is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@vuule vuule

Labels
improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vuule @bdice @davidwendt