Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable dict support for split-page kernel in the parquet reader. #16128

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Disable dict support for split-page kernel in the parquet reader. #16128

merged 1 commit into from
Jul 10, 2024

Conversation

nvdbaranec
Copy link
Contributor

Dictionary support for this particular flavor of kernel was being compiled in. Harmless, but caused an unneeded increase in shared memory usage. This PR disables it.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@nvdbaranec nvdbaranec added libcudf Affects libcudf (C++/CUDA) code. cuIO cuIO issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 28, 2024
@nvdbaranec nvdbaranec requested a review from a team as a code owner June 28, 2024 18:17
@nvdbaranec
Copy link
Contributor Author

nvdbaranec commented Jun 28, 2024 •
edited
Loading

@etseidl
(Github still refusing to let me tag you as a reviewer).

etseidl
etseidl approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@etseidl etseidl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@nvdbaranec
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 7b8169a into rapidsai:branch-24.08 Jul 10, 2024
76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmattione-nvidia pmattione-nvidia pmattione-nvidia approved these changes

@etseidl etseidl etseidl approved these changes

@mythrocks mythrocks mythrocks approved these changes

Assignees
No one assigned
Labels
cuIO cuIO issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nvdbaranec @mythrocks @etseidl @pmattione-nvidia