Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow only scale=0 fixed-point values in fixed_width_column_wrapper #16120

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

davidwendt
Copy link
Contributor

@davidwendt davidwendt commented Jun 27, 2024

Description

The cudf::test::fixed_width_column_wrapper supports all fixed-width type including fixed-point types. However, there is no mechanism to specify the fixed-point scale value which is common for the entire column and stored in the column's type.
This fixes the case by throwing an error if a non-zero scale is specified for the input values in a fixed-point fixed_width_column_wrapper instance.

Also fixed several tests that incorrectly specified a non-zero scale.

Closes #16092

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added bug Something isn't working 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Jun 27, 2024
@davidwendt davidwendt self-assigned this Jun 27, 2024
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Jun 28, 2024
@davidwendt davidwendt marked this pull request as ready for review June 28, 2024 17:45
@davidwendt davidwendt requested a review from a team as a code owner June 28, 2024 17:45
@davidwendt davidwendt requested review from vyasr and bdice June 28, 2024 17:45
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit b06d883 into rapidsai:branch-24.08 Jul 11, 2024
82 checks passed
@davidwendt davidwendt deleted the fww-no-fp branch July 11, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Column type for fixed_width_column_wrapper should be restricted.
3 participants