Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pylibcudf Table.num_rows for 0 columns case and add interop to docs #16108

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Fix pylibcudf Table.num_rows for 0 columns case and add interop to docs #16108

merged 1 commit into from
Jun 27, 2024

Conversation

lithomas1
Copy link
Contributor

@lithomas1 lithomas1 commented Jun 27, 2024 •
edited
Loading

Description

There was a bug where Table.num_rows raised when we had 0 columns instead of returning 0.
I also added interop to the docs since that was missing.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@lithomas1 lithomas1 added bug Something isn't working doc Documentation non-breaking Non-breaking change labels Jun 27, 2024
@github-actions github-actions bot added Python Affects Python cuDF API. pylibcudf Issues specific to the pylibcudf package labels Jun 27, 2024
@lithomas1 lithomas1 removed the doc Documentation label Jun 27, 2024
@lithomas1 lithomas1 marked this pull request as ready for review June 27, 2024 00:45
@lithomas1 lithomas1 requested a review from a team as a code owner June 27, 2024 00:45
@wence-
Copy link
Contributor

wence- commented Jun 27, 2024

/merge

@rapids-bot rapids-bot bot merged commit e98d456 into rapidsai:branch-24.08 Jun 27, 2024
91 checks passed
@lithomas1 lithomas1 deleted the pylibcudf-fixes branch June 27, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@galipremsagar galipremsagar Awaiting requested review from galipremsagar galipremsagar is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Non-breaking change pylibcudf Issues specific to the pylibcudf package Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lithomas1 @wence- @mroeschke