Expose and then implement support for cross joins in cudf-polars #16097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Python
wence-
added
improvement
| ) | ||
|
|
||
| pleft = plc.interop.from_arrow(left) | ||
| pright = plc.interop.from_arrow(right) |
There was a problem hiding this comment.
We might consider fixturizing at least the GPU objects here
There was a problem hiding this comment.
Given that there's only one value, and one test, I am inclined not to, unless there is a really compelling reason.
brandon-b-miller
approved these changes
Jun 26, 2024
wence-
commented
Jun 26, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
libcudf supports cross joins, but until now this wasn't exposed to python. Do that in pylibcudf and implement the evaluation rule in cudf-polars.
Checklist