Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support quantile in cudf_polars #16093

Merged
merged 4 commits into from
Aug 29, 2024
Merged

Support quantile in cudf_polars #16093

merged 4 commits into from
Aug 29, 2024

Conversation

lithomas1
Copy link
Contributor

@lithomas1 lithomas1 commented Jun 25, 2024 •
edited by vyasr
Loading

Description

Support pl.Expr.quantile in cudf-polars.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@lithomas1 lithomas1 added feature request New feature or request non-breaking Non-breaking change labels Jun 25, 2024
@github-actions github-actions bot added Python Affects Python cuDF API. cudf.polars Issues specific to cudf.polars labels Jun 25, 2024
@wence-
Copy link
Contributor

wence- commented Jun 26, 2024 •
edited
Loading

Needs Lawrence's changes to the IR to be upstreamed to polars first.

pola-rs/polars#17209

wence-
wence- requested changes Jun 26, 2024
View reviewed changes
python/cudf_polars/tests/expressions/test_agg.py Outdated Show resolved Hide resolved
python/cudf_polars/cudf_polars/dsl/expr.py Outdated Show resolved Hide resolved
python/cudf_polars/cudf_polars/dsl/expr.py Outdated Show resolved Hide resolved
python/cudf_polars/cudf_polars/dsl/expr.py Outdated Show resolved Hide resolved
python/cudf_polars/cudf_polars/dsl/expr.py Outdated Show resolved Hide resolved
wence-
wence- requested changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be simplified a bit

python/cudf_polars/cudf_polars/dsl/expr.py Outdated Show resolved Hide resolved
python/cudf_polars/tests/expressions/test_agg.py Outdated Show resolved Hide resolved
python/cudf_polars/cudf_polars/dsl/expr.py Outdated Show resolved Hide resolved
python/cudf_polars/cudf_polars/dsl/expr.py Outdated Show resolved Hide resolved
python/cudf_polars/cudf_polars/dsl/expr.py Outdated Show resolved Hide resolved
python/cudf_polars/cudf_polars/dsl/expr.py Outdated Show resolved Hide resolved
@wence-
Copy link
Contributor

wence- commented Jul 16, 2024

@lithomas1 are you going to try and get this in for 24.08?

@lithomas1
Copy link
Contributor Author

Let's let this one slip to 24.10.

@lithomas1 lithomas1 changed the base branch from branch-24.08 to branch-24.10 July 25, 2024 20:10
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Aug 22, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@vyasr vyasr changed the base branch from branch-24.10 to feature/cudf-polars August 28, 2024 00:09
@vyasr vyasr marked this pull request as ready for review August 28, 2024 18:17
@vyasr vyasr requested a review from a team as a code owner August 28, 2024 18:17
@vyasr vyasr requested review from vyasr, charlesbluca and wence- and removed request for a team August 28, 2024 18:17
@vyasr
Copy link
Contributor

vyasr commented Aug 28, 2024

/ok to test

wence-
wence- approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lithomas1 and @vyasr

@wence- wence- merged commit 40d33cb into rapidsai:feature/cudf-polars Aug 29, 2024
100 of 101 checks passed
@lithomas1 lithomas1 deleted the polars-quantile branch August 29, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wence- wence- wence- approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr was automatically assigned from rapidsai/cudf-python-codeowners

@charlesbluca charlesbluca Awaiting requested review from charlesbluca charlesbluca was automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
cudf.polars Issues specific to cudf.polars feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lithomas1 @wence- @vyasr