Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TPC-H inspired examples for Libcudf #16088

Merged
merged 125 commits into from
Jul 17, 2024
Merged

Add TPC-H inspired examples for Libcudf #16088

merged 125 commits into from
Jul 17, 2024

Conversation

JayjeetAtGithub
Copy link
Contributor

@JayjeetAtGithub JayjeetAtGithub commented Jun 25, 2024 •
edited
Loading

This PR adds a suite of libcudf examples with queries inspired from the TPC-H benchmarks. This PR also adds some reusable helper functions to perform operations such as joins, groubys, and orderbys for a cleaner and modular implementation of the queries.

Queries implemented so far:

  • Query 1
  • Query 5
  • Query 6
  • Query 9

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Jun 25, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue labels Jun 25, 2024
@karthikeyann karthikeyann added non-breaking Non-breaking change Performance Performance related issue labels Jun 28, 2024
@JayjeetAtGithub
Copy link
Contributor Author

/ok to test

@JayjeetAtGithub JayjeetAtGithub mentioned this pull request Jun 28, 2024
Open
@GregoryKimball
Copy link
Contributor

@JayjeetAtGithub would you please split the fixed_point literals change into a separate PR?

@JayjeetAtGithub
Copy link
Contributor Author

Sure @GregoryKimball

@mhaseeb123 mhaseeb123 self-requested a review June 28, 2024 22:53
@karthikeyann karthikeyann added the feature request New feature or request label Jul 1, 2024
@mhaseeb123
Copy link
Member

Thanks for working on this @JayjeetAtGithub! I will review it promptly. Meanwhile, could you please update the description (should mostly be copy-paste + some other details from the README) and briefly detail what this PR is all about! Thanks

mhaseeb123
mhaseeb123 reviewed Jul 1, 2024
View reviewed changes
Copy link
Member

@mhaseeb123 mhaseeb123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review.

@JayjeetAtGithub JayjeetAtGithub marked this pull request as ready for review July 2, 2024 23:43
@JayjeetAtGithub JayjeetAtGithub requested a review from a team as a code owner July 2, 2024 23:43
@JayjeetAtGithub
Copy link
Contributor Author

/ok to test

@JayjeetAtGithub
Copy link
Contributor Author

/ok to test

mhaseeb123
mhaseeb123 requested changes Jul 16, 2024
View reviewed changes
Copy link
Member

@mhaseeb123 mhaseeb123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cudf namespace should be renamed to at least cudf::examples

@JayjeetAtGithub
Copy link
Contributor Author

/ok to test

mhaseeb123
mhaseeb123 approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@mhaseeb123 mhaseeb123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for persistently following up on this!

@JayjeetAtGithub
Copy link
Contributor Author

/ok to test

karthikeyann
karthikeyann approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@karthikeyann karthikeyann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍
Thank you for working on this.

@JayjeetAtGithub
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 34dea6f into rapidsai:branch-24.08 Jul 17, 2024
87 of 92 checks passed
@JayjeetAtGithub
Copy link
Contributor Author

/merge

@GregoryKimball GregoryKimball mentioned this pull request Aug 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhaseeb123 mhaseeb123 mhaseeb123 approved these changes

@karthikeyann karthikeyann karthikeyann approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@davidwendt davidwendt Awaiting requested review from davidwendt davidwendt is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@harrism harrism Awaiting requested review from harrism

@wence- wence- Awaiting requested review from wence-

@PointKernel PointKernel Awaiting requested review from PointKernel

@bdice bdice Awaiting requested review from bdice

Assignees

@JayjeetAtGithub JayjeetAtGithub

Labels
CMake CMake build issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Performance Performance related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@JayjeetAtGithub @GregoryKimball @mhaseeb123 @bdice @harrism @wence- @karthikeyann @PointKernel