-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce (shallow) copies in DataFrame ops #16060
Reduce (shallow) copies in DataFrame ops #16060
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question, should I read this statement:
shallow copies instead of deep copies like pandas
To mean "perform shallow copies like pandas, instead of the previous deep copies"?
Or "perform shallow copies, unlike pandas which does deep copies"?
I presume the former?
Yes, this is what I intended to communicate. Sorry for the lack of clarity |
I actually noticed my copy comparisons to pandas was based on the pandas main branch which has copy-on-write enabled and therefore shallow copies could be made instead of deep copies. I reverted changes to the APIs where I changed the deep copy behavior and added a comment instead for a future change with copy on write. |
I reran things, based on hopefully rapidsai/shared-workflows#221 being fixed |
Changes to shared workflows will require pushing an empty commit to restart CI, IIRC just rerunning jobs will reuse the cached workflows from before. |
/merge |
Description
In particular for ops which only modify the axes
DataFrame.rename
DataFrame.to_arrow
until necessaryAlso fixes a bug in
DataFrame.rename
to maintain the originaldtype
of thecolumns
after renamingChecklist