Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce deep copies in Index ops #16054

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Reduce deep copies in Index ops #16054

merged 2 commits into from
Jun 18, 2024

Conversation

mroeschke
Copy link
Contributor

@mroeschke mroeschke commented Jun 18, 2024 •
edited
Loading

Description

  1. Changed Index.rename(inplace=False) to shallow copy which matches pandas behavior. Let me know if there's a reason why we should deep copy here.
  2. Made RangeIndex.unique return a shallow copy like pandas.
  3. Made Index.dropna with no NA's shallow copy like pandas.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 18, 2024
@mroeschke mroeschke requested a review from a team as a code owner June 18, 2024 00:06
@mroeschke mroeschke requested review from isVoid and lithomas1 June 18, 2024 00:06
@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit fc4b3d3 into rapidsai:branch-24.08 Jun 18, 2024
82 checks passed
@mroeschke mroeschke deleted the per/copies branch June 18, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galipremsagar galipremsagar galipremsagar approved these changes

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@lithomas1 lithomas1 Awaiting requested review from lithomas1 lithomas1 is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @galipremsagar