Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix atomic_ref scope when multiple blocks are updating the same output #16051

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

vuule
Copy link
Contributor

@vuule vuule commented Jun 17, 2024

Description

in a few places, thread_scope_block is used even where there threads from multiple blocks update the same location. This PR changes these to thread_scope_device to avoid UB with sufficiently large inputs.

Have not ran benchmarks to evaluate the impact.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vuule vuule added bug Something isn't working non-breaking Non-breaking change labels Jun 17, 2024
@vuule vuule self-assigned this Jun 17, 2024
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Jun 17, 2024
@vuule vuule marked this pull request as ready for review June 17, 2024 23:21
@vuule vuule requested a review from a team as a code owner June 17, 2024 23:21
Copy link
Member

@PointKernel PointKernel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks for the fix!

@vuule
Copy link
Contributor Author

vuule commented Jun 18, 2024

/merge

@rapids-bot rapids-bot bot merged commit 7ff2764 into rapidsai:branch-24.08 Jun 18, 2024
73 checks passed
@vuule vuule deleted the bug-thread_scope_block branch June 18, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants