Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exception when trying to create large strings with cudf::test::strings_column_wrapper #16049

Merged

Conversation

davidwendt
Copy link
Contributor

Description

Throws an exception in the cudf::test::strings_column_wrapper if the column size (accumulated offset values) would exceed max size_type.
Large strings created by the wrapper are not supported and discouraged due to the size and time impact on testing and CI.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 17, 2024
@davidwendt davidwendt self-assigned this Jun 17, 2024
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Jun 24, 2024
@davidwendt davidwendt marked this pull request as ready for review June 24, 2024 15:04
@davidwendt davidwendt requested a review from a team as a code owner June 24, 2024 15:04
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit bfaddd3 into rapidsai:branch-24.08 Jun 26, 2024
73 checks passed
@davidwendt davidwendt deleted the throw-ls-strings-wrapper branch June 26, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants