Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return FrozenList for Index.names #16047

Merged
merged 4 commits into from
Jun 17, 2024
Merged

Return FrozenList for Index.names #16047

merged 4 commits into from
Jun 17, 2024

Conversation

galipremsagar
Copy link
Contributor

Description

Fixes: #16046

This PR returns FrozenList for Index.names instead of tuple.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added improvement Improvement / enhancement to an existing function breaking Breaking change labels Jun 17, 2024
@galipremsagar galipremsagar self-assigned this Jun 17, 2024
@galipremsagar galipremsagar requested review from a team as code owners June 17, 2024 02:35
@galipremsagar galipremsagar requested review from bdice and Matt711 June 17, 2024 02:35
@github-actions github-actions bot added the Python Affects Python cuDF API. label Jun 17, 2024
bdice
bdice approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with two small requests.

python/cudf/cudf/core/_base_index.py Outdated Show resolved Hide resolved
python/dask_cudf/dask_cudf/io/parquet.py Outdated Show resolved Hide resolved
galipremsagar and others added 2 commits June 16, 2024 22:43
@galipremsagar @bdice
Update parquet.py
bafea94 
Co-authored-by: Bradley Dice <[email protected]>
@galipremsagar @bdice
Update _base_index.py
7ef3187 
Co-authored-by: Bradley Dice <[email protected]>
@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit a023d5f into rapidsai:branch-24.08 Jun 17, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@wence- wence- wence- approved these changes

@Matt711 Matt711 Awaiting requested review from Matt711 Matt711 is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
breaking Breaking change improvement Improvement / enhancement to an existing function Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Index.names return tuple instead of FrozenList
3 participants
@galipremsagar @wence- @bdice