Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ruff rules to avoid importing from typing #16040

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

mroeschke
Copy link
Contributor

@mroeschke mroeschke commented Jun 14, 2024

Description

Enabled the following ruff rules to update typing annotations according to PEP585 and PEP604

https://docs.astral.sh/ruff/rules/future-rewritable-type-annotation/
https://docs.astral.sh/ruff/rules/non-pep604-annotation/
https://docs.astral.sh/ruff/rules/non-pep585-annotation/

The changes were made by running pre-commit run ruff --all-files with fix = True and unsafe-fixes = True locally

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 14, 2024
@mroeschke mroeschke requested review from a team as code owners June 14, 2024 21:16
@github-actions github-actions bot added the cudf.pandas Issues specific to cudf.pandas label Jun 14, 2024
@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 87f6a7e into rapidsai:branch-24.08 Jun 17, 2024
80 checks passed
@mroeschke mroeschke deleted the sty/type/ruff branch June 17, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cudf.pandas Issues specific to cudf.pandas improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants