Reduce conditional_join nvbench configurations #16036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srinivasyadav18
added
Performance
srinivasyadav18
added
the
improvement
PointKernel
approved these changes
Jun 14, 2024
There was a problem hiding this comment.
@srinivasyadav18 can you please add a comment explaining why the custom range is needed for conditional join?
Looks great! Thanks!
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current JOIN_NVBENCH uses three table sizes
1000, 100'000, 10'000'000for all the join benchmarks.But, coditional joins perform X * Y operations, and the large table size explodes the bench runtime. Hence we need to benchmark on smaller tables only.
This PR reduces nvbench configurations from 36 to 16 by using only two smaller table sizes
1000, 100'000which lowers the overall benchmark runtime significantly.Checklist