Project automation update: skip if not in project #16035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarmak-nv
added
non-breaking
jameslamb
approved these changes
Jun 14, 2024
There was a problem hiding this comment.
Reviewing because I was randomly chosen via CODEOWNERS.
This implementation looks fine to me based on the code I see at https://github.com/rapidsai/shared-workflows/blob/5fd16903025d905373bca6976b08f4db315e7c80/.github/workflows/project-get-item-id.yaml#L44.
But I don't know the context for this work so don't take my approval as an endorsement of skipping issues that are not in some project.
vyasr
approved these changes
Jun 14, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds another condition to when we should run the automation work. PRs aren't always in the cuDF Python project so when this is the case we should skip the job rather than attempting to run it and have it throw an error.
Checklist
New or existing tests cover these changes.The documentation is up to date with these changes.