Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the int32 overflow when computing page fragment sizes for large string columns #16028

Merged
merged 2 commits into from
Jun 14, 2024
Merged

Fix the int32 overflow when computing page fragment sizes for large string columns #16028

merged 2 commits into from
Jun 14, 2024

Conversation

mhaseeb123
Copy link
Member

Description

This PR fixes the possible int32 overflow when computing page fragment sizes for large (2B+ char) string columns.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mhaseeb123 mhaseeb123 requested a review from a team as a code owner June 13, 2024 23:53
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Jun 13, 2024
@mhaseeb123 mhaseeb123 requested a review from vuule June 13, 2024 23:54
@vuule vuule added bug Something isn't working non-breaking Non-breaking change cuIO cuIO issue labels Jun 13, 2024
@mhaseeb123 mhaseeb123 added the 3 - Ready for Review Ready for review by team label Jun 13, 2024
@mhaseeb123 mhaseeb123 changed the title Fix the int32 overflow when computing page fragment sizes for large (2B+ char) string columns Fix the int32 overflow when computing page fragment sizes for large string columns Jun 14, 2024
@mhaseeb123
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 829b3a9 into rapidsai:branch-24.08 Jun 14, 2024
79 checks passed
@mhaseeb123 mhaseeb123 deleted the pq-large-strings-zstd-comp branch June 14, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vuule vuule vuule approved these changes

@ttnghia ttnghia ttnghia approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@pmattione-nvidia pmattione-nvidia Awaiting requested review from pmattione-nvidia pmattione-nvidia is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team bug Something isn't working cuIO cuIO issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mhaseeb123 @ttnghia @vuule