Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the pool size alignment issue #16024

Merged
merged 4 commits into from
Jun 14, 2024

Conversation

PointKernel
Copy link
Member

@PointKernel PointKernel commented Jun 13, 2024

Description

This PR fixes a pool size alignment bug.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@PointKernel PointKernel added bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Jun 13, 2024
@PointKernel PointKernel requested a review from a team as a code owner June 13, 2024 21:32
@PointKernel
Copy link
Member Author

Depending on how reviewers see this,

: pool_size_{size}, pool_{new host_pooled_mr(upstream_mr_, size, size)}
Is the fixed_pinned_pool_memory_resource ctor is a better place to do this round up calculation?

@bdice
Copy link
Contributor

bdice commented Jun 13, 2024

Is the fixed_pinned_pool_memory_resource ctor is a better place to do this round up calculation?

Yes, I think so. It guarantees a higher degree of safety because make_default_pinned_mr will go through that constructor.

@PointKernel
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 987879c into rapidsai:branch-24.08 Jun 14, 2024
85 checks passed
@PointKernel PointKernel deleted the fix-pool-alignment branch June 14, 2024 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants