-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the pool size alignment issue #16024
Merged
rapids-bot
merged 4 commits into
rapidsai:branch-24.08
from
PointKernel:fix-pool-alignment
Jun 14, 2024
Merged
Fix the pool size alignment issue #16024
rapids-bot
merged 4 commits into
rapidsai:branch-24.08
from
PointKernel:fix-pool-alignment
Jun 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PointKernel
added
bug
Something isn't working
libcudf
Affects libcudf (C++/CUDA) code.
non-breaking
Non-breaking change
labels
Jun 13, 2024
harrism
approved these changes
Jun 13, 2024
Depending on how reviewers see this, cudf/cpp/src/utilities/pinned_memory.cpp Line 46 in 3cb3df3
fixed_pinned_pool_memory_resource ctor is a better place to do this round up calculation?
|
Yes, I think so. It guarantees a higher degree of safety because |
vuule
approved these changes
Jun 13, 2024
davidwendt
approved these changes
Jun 13, 2024
/merge |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
libcudf
Affects libcudf (C++/CUDA) code.
non-breaking
Non-breaking change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a pool size alignment bug.
Checklist