Support IntervalDtype in cudf.from_pandas #16014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
bug
…ndas/intervaldtype
bdice
approved these changes
Jun 13, 2024
wence-
approved these changes
Jun 13, 2024
python/cudf/cudf/core/dataframe.py
Outdated
| @@ -8072,6 +8072,8 @@ def from_pandas(obj, nan_as_null=no_default): | |||
| return cudf.Index.from_pandas(obj, nan_as_null=nan_as_null) | |||
| elif isinstance(obj, pd.CategoricalDtype): | |||
| return cudf.CategoricalDtype.from_pandas(obj) | |||
| elif isinstance(obj, pd.IntervalDtype): | |||
| return cudf.IntervalDtype.from_pandas(obj) | |||
| else: | |||
| raise TypeError( | |||
| "from_pandas only accepts Pandas Dataframes, Series, " | |||
There was a problem hiding this comment.
nit: this error string is increasingly out of date (it doesn't mention categoricaldtype and now intervaldtype). Should we reword the be less specific?
f"from_pandas unsupported for object of type {type(obj)}"
perhaps?
There was a problem hiding this comment.
Sure thing. Changed to this
galipremsagar
approved these changes
Jun 13, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Noticed while running the pandas test suite against
cudf.pandasChecklist