-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
orc multithreaded benchmark #16009
orc multithreaded benchmark #16009
Conversation
Ah I forgot to sign the commit |
Signed-off-by: Zach Puller <[email protected]>
/ok to test |
/ok to test |
Signed-off-by: Zach Puller <[email protected]>
/ok to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a small concern with the use of nvtx
otherwise looks great!
Signed-off-by: Zach Puller <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some non-blocking cleanups. LGTM
Thanks for the contribution!
Co-authored-by: Yunsong Wang <[email protected]>
Signed-off-by: Zach Puller <[email protected]>
/ok to test |
That does apply to the Spark RAPIDS projects, though. |
Signed-off-by: Zach Puller <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! A couple of minor nitpicks.
Co-authored-by: MithunR <[email protected]>
Signed-off-by: Zach Puller <[email protected]>
/ok to test |
/ok to test |
/merge |
Thanks for doing this one, @zpuller. I've merged this change. |
Description
Addresses: #15973
Adds multithreaded benchmarks for the ORC reader. Based off of the parquet equivalent in #15585
Checklist