Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests of expression-based sort and sort-by #16008

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

wence-
Copy link
Contributor

@wence- wence- commented Jun 12, 2024

Description

We only need stable vs unstable variants for the sort-by case, since when sorting a single column by itself there is no distinction between stable and unstable.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

We only need stable vs unstable variants for the sort-by case, since
when sorting a single column by itself there is no distinction between
stable and unstable.
@wence- wence- added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 12, 2024
@wence- wence- requested a review from a team as a code owner June 12, 2024 16:34
@wence- wence- requested review from vyasr and Matt711 June 12, 2024 16:34
@github-actions github-actions bot added Python Affects Python cuDF API. cudf.polars Issues specific to cudf.polars labels Jun 12, 2024
@vyasr
Copy link
Contributor

vyasr commented Jun 24, 2024

/merge

@rapids-bot rapids-bot bot merged commit 525ca7e into rapidsai:branch-24.08 Jun 24, 2024
80 checks passed
@wence- wence- deleted the wence/fea/test-expr-sort branch June 25, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cudf.polars Issues specific to cudf.polars improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants