Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add coverage selecting len from a dataframe (number of rows) #16005

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Add coverage selecting len from a dataframe (number of rows) #16005

merged 1 commit into from
Jun 13, 2024

Conversation

wence-
Copy link
Contributor

@wence- wence- commented Jun 12, 2024

Description

Fix bug (and report a polars issue) for the case that the dataframe is empty, and therefore we cannot ask a column for its length.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@wence-
Add coverage selecting len from a dataframe (number of rows)
5c93384 
Fix bug (and report a polars issue) for the case that the dataframe is
empty, and therefore we cannot ask a column for its length.
@wence- wence- added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 12, 2024
@wence- wence- requested a review from a team as a code owner June 12, 2024 16:18
@wence- wence- requested review from bdice and brandon-b-miller June 12, 2024 16:18
@github-actions github-actions bot added Python Affects Python cuDF API. cudf.polars Issues specific to cudf.polars labels Jun 12, 2024
@wence- wence- mentioned this pull request Jun 12, 2024
Closed
3 tasks
@wence-
Copy link
Contributor Author

wence- commented Jun 13, 2024

/merge

@rapids-bot rapids-bot bot merged commit 8bbc512 into rapidsai:branch-24.08 Jun 13, 2024
76 checks passed
@wence- wence- deleted the wence/fea/test-expr-len branch June 13, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@brandon-b-miller brandon-b-miller Awaiting requested review from brandon-b-miller brandon-b-miller is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
cudf.polars Issues specific to cudf.polars improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wence- @bdice