Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic tests of dataframe scan #16003

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Add basic tests of dataframe scan #16003

merged 2 commits into from
Jun 19, 2024

Conversation

wence-
Copy link
Contributor

@wence- wence- commented Jun 12, 2024

Description

Also assert that unsupported file scan operations raise.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@wence- wence- added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 12, 2024
@wence- wence- requested a review from a team as a code owner June 12, 2024 15:58
@wence- wence- requested review from vyasr and charlesbluca June 12, 2024 15:58
@github-actions github-actions bot added Python Affects Python cuDF API. cudf.polars Issues specific to cudf.polars labels Jun 12, 2024
@wence- wence- mentioned this pull request Jun 12, 2024
Closed
3 tasks
@wence-
Add basic tests of dataframe scan
3230096 
Also assert that unsupported file scan operations raise.
@wence- wence- force-pushed the wence/fea/scan-coverage branch from c2f207d to 3230096 Compare June 14, 2024 09:52
brandon-b-miller
brandon-b-miller approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@brandon-b-miller brandon-b-miller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question otherwise LGTM

@wence-
Copy link
Contributor Author

wence- commented Jun 18, 2024

/merge

@rapids-bot rapids-bot bot merged commit f536e30 into rapidsai:branch-24.08 Jun 19, 2024
80 checks passed
@wence- wence- deleted the wence/fea/scan-coverage branch June 19, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandon-b-miller brandon-b-miller brandon-b-miller approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@charlesbluca charlesbluca Awaiting requested review from charlesbluca charlesbluca is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
cudf.polars Issues specific to cudf.polars improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wence- @brandon-b-miller