Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add full coverage for whole-frame Agg expressions #15997

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Add full coverage for whole-frame Agg expressions #15997

merged 1 commit into from
Jun 24, 2024

Conversation

wence-
Copy link
Contributor

@wence- wence- commented Jun 12, 2024

Description

Also add more expansive comments on the unreachable paths.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@wence-
Add full coverage for whole-frame Agg expressions
e2c34f6 
Also add more expansive comments on the unreachable paths.
@wence- wence- requested a review from a team as a code owner June 12, 2024 13:50
@wence- wence- requested review from isVoid and Matt711 June 12, 2024 13:50
@github-actions github-actions bot added Python Affects Python cuDF API. cudf.polars Issues specific to cudf.polars labels Jun 12, 2024
@wence- wence- added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 12, 2024
@wence- wence- mentioned this pull request Jun 12, 2024
Closed
3 tasks
@wence-
Copy link
Contributor Author

wence- commented Jun 24, 2024

/merge

@rapids-bot rapids-bot bot merged commit f3183c1 into rapidsai:branch-24.08 Jun 24, 2024
75 checks passed
@wence- wence- deleted the wence/fea/agg-coverage branch June 24, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lithomas1 lithomas1 lithomas1 approved these changes

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@Matt711 Matt711 Awaiting requested review from Matt711 Matt711 is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
cudf.polars Issues specific to cudf.polars improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wence- @lithomas1