Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add full coverage of utility functions #15995

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Add full coverage of utility functions #15995

merged 1 commit into from
Jun 24, 2024

Conversation

wence-
Copy link
Contributor

@wence- wence- commented Jun 12, 2024

Description

The datetime conversion tests just test that we can round-trip correctly for now.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@wence-
Add full coverage of utility functions
8e81de7 
The datetime conversion tests just test that we can round-trip
correctly for now.
@wence- wence- added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 12, 2024
@wence- wence- requested review from a team as code owners June 12, 2024 13:33
@github-actions github-actions bot added Python Affects Python cuDF API. cudf.polars Issues specific to cudf.polars labels Jun 12, 2024
@wence- wence- mentioned this pull request Jun 12, 2024
Closed
3 tasks
@wence-
Copy link
Contributor Author

wence- commented Jun 18, 2024

@KyleFromNVIDIA barring your comments, were you happy with the pyproject changes, or is there something I should be doing?

@wence-
Copy link
Contributor Author

wence- commented Jun 19, 2024

/merge

@vyasr vyasr requested a review from KyleFromNVIDIA June 24, 2024 17:47
@rapids-bot rapids-bot bot merged commit 4d4cdce into rapidsai:branch-24.08 Jun 24, 2024
75 checks passed
@wence- wence- deleted the wence/fea/util-tests branch June 24, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KyleFromNVIDIA KyleFromNVIDIA KyleFromNVIDIA approved these changes

@lithomas1 lithomas1 lithomas1 approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
cudf.polars Issues specific to cudf.polars improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wence- @lithomas1 @KyleFromNVIDIA