Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve dependency-file-generator warning, remove unnecessary rapids-build-backend configuration #15980

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

jameslamb
Copy link
Member

Description

Contributes to rapidsai/build-planning#31
Contributes to rapidsai/dependency-file-generator#89

#15245 was one of the first rapids-build-backend PRs merged across RAPIDS. Since it was merged, we've made some small adjustments to the approach for rapids-build-backend. This catches cudf up with those changes:

  • consolidates version-handling in ci/build_cpp.sh
  • removes commit-file configuration in pyproject.toml
  • uses --file-key instead of --file_key in rapids-dependency-file-generator calls

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jameslamb jameslamb added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 11, 2024
@jameslamb jameslamb requested review from a team as code owners June 11, 2024 20:24
@github-actions github-actions bot added Python Affects Python cuDF API. cudf.polars Issues specific to cudf.polars labels Jun 12, 2024
@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit c0c2ad3 into rapidsai:branch-24.08 Jun 12, 2024
75 checks passed
@jameslamb jameslamb deleted the more-rapids-build-backend branch June 12, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cudf.polars Issues specific to cudf.polars improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants