Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add typing to single_column_frame #15965

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Add typing to single_column_frame #15965

merged 2 commits into from
Jun 11, 2024

Conversation

mroeschke
Copy link
Contributor

Description

Also removes an extra copy from .flatten() when calling .values or .values_host

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change cuDF (Python) labels Jun 10, 2024
@mroeschke mroeschke requested a review from a team as a code owner June 10, 2024 23:48
@mroeschke mroeschke requested review from vyasr and lithomas1 June 10, 2024 23:48
@github-actions github-actions bot added the Python Affects Python cuDF API. label Jun 10, 2024
lithomas1
lithomas1 approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@lithomas1 lithomas1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mroeschke!

@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 570df6c into rapidsai:branch-24.08 Jun 11, 2024
70 checks passed
@mroeschke mroeschke deleted the typ/scf branch June 11, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lithomas1 lithomas1 lithomas1 approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mroeschke @lithomas1 @vyasr