Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused parsing utilities #15955

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Remove unused parsing utilities #15955

merged 1 commit into from
Jun 7, 2024

Conversation

vuule
Copy link
Contributor

@vuule vuule commented Jun 7, 2024

Description

Some parsing utilities have been unused since legacy JSON removal.
This PR removes these functions.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vuule vuule added cuIO cuIO issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 7, 2024
@vuule vuule self-assigned this Jun 7, 2024
@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue labels Jun 7, 2024
@vuule vuule marked this pull request as ready for review June 7, 2024 20:26
@vuule vuule requested review from a team as code owners June 7, 2024 20:26
@vuule vuule requested review from vyasr and pmattione-nvidia June 7, 2024 20:26
bdice
bdice approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted!

@vuule
Copy link
Contributor Author

vuule commented Jun 7, 2024

/merge

@rapids-bot rapids-bot bot merged commit 8e40fe7 into rapidsai:branch-24.08 Jun 7, 2024
70 checks passed
@vuule vuule deleted the remove-unused-parsing_utils branch June 7, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttnghia ttnghia ttnghia approved these changes

@bdice bdice bdice approved these changes

@vyasr vyasr vyasr approved these changes

@pmattione-nvidia pmattione-nvidia Awaiting requested review from pmattione-nvidia pmattione-nvidia is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@vuule vuule

Labels
CMake CMake build issue cuIO cuIO issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vuule @vyasr @bdice @ttnghia