Remove Scalar container type from polars interpreter
#15953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Python
wence-
commented
Jun 7, 2024
Comment on lines
-52
to
-54
| [tool.setuptools.packages.find] | ||
| exclude = ["*tests*"] | ||
|
|
There was a problem hiding this comment.
This was doing the wrong thing, the default find works correctly. With this exclusion, if you did a pip install . then the contents of the build directory would be discovered, producing a nested recursive mess of horror.
wence-
added
improvement
Now we always return columns and, where usage of a scalar might be correct (for example broadcasting in binops), we check if the column is "actually" a scalar and extract it. This is slightly annoying because we have to introspect things in various places. But without changing libcudf to treat length-1 columns as always broadcastable like scalars this is, I think, the best we can do.
wence-
force-pushed
the
wence/fea/no-scalar-container
branch
from
99348d5 to
1f22fdf
Compare
|
Addressed comments and added test |
brandon-b-miller
approved these changes
Jun 10, 2024
jameslamb
approved these changes
Jun 10, 2024
vyasr
approved these changes
Jun 10, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now we always return columns and, where usage of a scalar might be
correct (for example broadcasting in binops), we check if the column
is "actually" a scalar and extract it.
This is slightly annoying because we have to introspect things in
various places. But without changing libcudf to treat length-1 columns
as always broadcastable like scalars this is, I think, the best we can
do.
Checklist