Support arbitrary CUDA versions in UDF code #15950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdice
added
improvement
3 tasks
bdice
changed the title
bdice
commented
Jun 9, 2024
Comment on lines
-175
to
-185
| ver_map = { | ||
| "7.5": (11, 5), | ||
| "7.6": (11, 6), | ||
| "7.7": (11, 7), | ||
| "7.8": (11, 8), | ||
| "8.0": (12, 0), | ||
| "8.1": (12, 1), | ||
| "8.2": (12, 2), | ||
| "8.3": (12, 3), | ||
| "8.4": (12, 4), | ||
| } |
There was a problem hiding this comment.
The main point of this PR is to get rid of this mapping!
gmarkall
approved these changes
Jun 10, 2024
brandon-b-miller
approved these changes
Jun 10, 2024
There was a problem hiding this comment.
Thanks @bdice , longstanding issue that I'm happy to see solved cleanly.
|
Thanks for the feedback @gmarkall @brandon-b-miller! I applied your feedback on naming. I'll go ahead and merge once CI passes. |
bdice
changed the title
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR eliminates the manual mapping from PTX versions to CUDA versions, to help support CUDA 12.5 and newer without requiring a manual update to
_numba.pyfor every CUDA release. This also updates the minimum compute capability PTX file from arch 60 to arch 70, since that is now the minimum required by RAPIDS.Checklist