Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support large strings in cudf::io::text::multibyte_split #15947

Merged

Conversation

davidwendt
Copy link
Contributor

Description

Replaces int32 type used for building offsets in cudf::io::text::multibyte_split() to use the offsetalator instead.
This allows creating large strings columns from input text files.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 6, 2024
@davidwendt davidwendt self-assigned this Jun 6, 2024
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Jun 6, 2024
@davidwendt davidwendt marked this pull request as ready for review June 6, 2024 21:08
@davidwendt davidwendt requested a review from a team as a code owner June 6, 2024 21:08
@davidwendt davidwendt requested review from harrism and bdice June 6, 2024 21:08
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 49e2a56 into rapidsai:branch-24.08 Jun 12, 2024
71 checks passed
@davidwendt davidwendt deleted the multibyte-split-offsets branch June 12, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants