Add more complete type annotations in polars interpreter #15942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No functional change intended. |
github-actions
bot
added
Python
wence-
added
improvement
jameslamb
approved these changes
Jun 6, 2024
wence-
commented
Jun 6, 2024
| @@ -62,8 +62,6 @@ target-version = "py39" | |||
| fix = true | |||
|
|
|||
| [tool.ruff.lint] | |||
| # __init__.py must re-export everything it imports | |||
| ignore-init-module-imports = false | |||
There was a problem hiding this comment.
This option is deprecated in ruff
wence-
commented
Jun 6, 2024
mroeschke
reviewed
Jun 6, 2024
mroeschke
approved these changes
Jun 6, 2024
wence-
force-pushed
the
wence/fea/polars-more-typing
branch
from
08fcafb to
d623879
Compare
We can check this with:
pyright --verifytypes cudf_polars --ignoreexternal
Which reports a "type completeness" score of around 94%. This will
improve once pylibcudf gets type stubs.
wence-
force-pushed
the
wence/fea/polars-more-typing
branch
from
d623879 to
019c95a
Compare
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We can check this with:
Which reports a "type completeness" score of around 94%. This will
improve once pylibcudf gets type stubs.
Checklist