Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix offsetalator when accessing over 268 million rows #15921

Merged

Conversation

davidwendt
Copy link
Contributor

Description

Fixes an access error when the offsetalator wraps an INT64 offsets column with more than 268,435,455 rows.
The row access type is size_type and is used to calculate the appropriate position within the offsets buffer.
This fix promotes the multiplication to int64 to properly resolve the correct pointer position.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added bug Something isn't working 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Jun 4, 2024
@davidwendt davidwendt self-assigned this Jun 4, 2024
@github-actions github-actions bot added the CMake CMake build issue label Jun 5, 2024
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Jun 5, 2024
@davidwendt davidwendt marked this pull request as ready for review June 5, 2024 20:47
@davidwendt davidwendt requested a review from a team as a code owner June 5, 2024 20:47
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 582d237 into rapidsai:branch-24.08 Jun 6, 2024
75 checks passed
@davidwendt davidwendt deleted the fix-offsetalator-many-rows branch June 6, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants