Avoid redefining Frame._get_columns_by_label in subclasses #15912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Python
charlesbluca
approved these changes
Jun 13, 2024
Comment on lines
+1445
to
+1448
| if by is None: | ||
| to_sort = self._columns | ||
| else: | ||
| to_sort = self._get_columns_by_label(list(by))._columns |
There was a problem hiding this comment.
Outside of dropping of downcast, is there any reason for the restructure here? Are there cases where we would expect the unpacking here not to work?
There was a problem hiding this comment.
This was mostly a micro-optimization to avoid the unnecessary unpacking of the if by is None case
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Frame._get_columns_by_labelwas redefined inSeriesandDataFrameto handle some special edge cases inDataFrame.__getitem__and emptySeriesBy making
_from_data_like_selfmore consistent in preserving external properties and moving special casing, we can only defineFrame._get_columns_by_labelonceChecklist