Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement exposed null mask APIs in pylibcudf #15908

Merged
merged 21 commits into from
Aug 30, 2024
Merged

Implement exposed null mask APIs in pylibcudf #15908

merged 21 commits into from
Aug 30, 2024

Conversation

charlesbluca
Copy link
Member

Description

Contributes to #15162

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added Python Affects Python cuDF API. CMake CMake build issue labels Jun 3, 2024
@charlesbluca charlesbluca added 2 - In Progress Currently a work in progress non-breaking Non-breaking change labels Jun 3, 2024
@charlesbluca charlesbluca self-assigned this Jun 3, 2024
@charlesbluca charlesbluca added the feature request New feature or request label Jun 3, 2024
@github-actions github-actions bot added the pylibcudf Issues specific to the pylibcudf package label Jun 4, 2024
@charlesbluca charlesbluca mentioned this pull request Jun 13, 2024
Closed
@charlesbluca charlesbluca marked this pull request as ready for review June 13, 2024 20:17
@charlesbluca charlesbluca requested a review from a team as a code owner June 13, 2024 20:17
@charlesbluca charlesbluca requested review from vyasr and isVoid June 13, 2024 20:17
@charlesbluca charlesbluca added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Jun 14, 2024
vyasr
vyasr requested changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small changes, but overall looks great!

python/cudf/cudf/_lib/null_mask.pyx Outdated Show resolved Hide resolved
python/cudf/cudf/_lib/pylibcudf/null_mask.pyx Outdated Show resolved Hide resolved
python/cudf/cudf/_lib/pylibcudf/null_mask.pyx Outdated Show resolved Hide resolved
python/cudf/cudf/_lib/pylibcudf/null_mask.pyx Outdated Show resolved Hide resolved
@vyasr vyasr changed the base branch from branch-24.08 to branch-24.10 August 16, 2024 16:27
@vyasr vyasr added the 5 - DO NOT MERGE Hold off on merging; see PR for details label Aug 16, 2024
@vyasr
Copy link
Contributor

vyasr commented Aug 16, 2024

Temporarily blocking on #16299 so that we can minimize conflicts there.

@github-actions github-actions bot removed the pylibcudf Issues specific to the pylibcudf package label Aug 29, 2024
@vyasr vyasr removed the 5 - DO NOT MERGE Hold off on merging; see PR for details label Aug 29, 2024
@vyasr vyasr force-pushed the pylibcudf-null_mask branch from 0b27f58 to 46954ee Compare August 30, 2024 01:08
@vyasr
Copy link
Contributor

vyasr commented Aug 30, 2024

/merge

@rapids-bot rapids-bot bot merged commit c6c720f into rapidsai:branch-24.10 Aug 30, 2024
85 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@charlesbluca charlesbluca

Labels
3 - Ready for Review Ready for review by team CMake CMake build issue feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charlesbluca @vyasr