Fix debug assert in rowgroup_char_counts_kernel #15902
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes assert triggered by
OrcWriterTest.EmptyChildStringColumn
in a Debug build.Error introduced in #15891 where offsetalator wraps an offsets column in the
cudf::io::orc::gpu::rowgroup_char_counts_kernel
.But when
num_rows==0
the offsets column isEMPTY
causing the assert to trigger.Checking the
num_rows
before accessing the offsets column fixes the issue.Checklist