Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use offsetalator in cudf::io::json::detail::parse_string #15900

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

davidwendt
Copy link
Contributor

Description

Updates the cudf::io::json::detail::parse_string function to use the offsetalator for building a strings column instead of size_type pointers. The output row sizes are computed in the first pass through the kernels and then converted to offsets. The offsets are wrapped with an offsetalator on the 2nd pass to locate each individual rows' output position in the chars data.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 31, 2024
@davidwendt davidwendt self-assigned this May 31, 2024
@GregoryKimball
Copy link
Contributor

Large strings in the JSON reader - here we come!! eventually ;)

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Jun 3, 2024
@davidwendt davidwendt marked this pull request as ready for review June 3, 2024 19:45
@davidwendt davidwendt requested a review from a team as a code owner June 3, 2024 19:45
Copy link
Member

@mhaseeb123 mhaseeb123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you for catching the std::cout in test

Copy link
Contributor

@karthikeyann karthikeyann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit d4dd474 into rapidsai:branch-24.08 Jun 6, 2024
71 checks passed
@davidwendt davidwendt deleted the data-cast-parse-ls branch June 6, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants