Rename strings multiple target replace API #15898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
2 - In Progress
github-actions
bot
added
Python
3 tasks
davidwendt
added
3 - Ready for Review
shrshi
approved these changes
May 31, 2024
ttnghia
reviewed
May 31, 2024
ttnghia
approved these changes
May 31, 2024
davidwendt
added
breaking
vyasr
approved these changes
Jun 3, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Renames the multi-target overload of
cudf::strings::replace()tocudf::strings::replace_multiple().This helps with some Cython issues involving fused types and overloaded functions with the same number of arguments.
Reference: #15855 (comment)
This change deprecates the old name to be removed in a future release.
Also added some additional error unit tests.
Closes #15855
Checklist