Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up pylibcudf test assertations #15892

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Clean up pylibcudf test assertations #15892

merged 2 commits into from
Jun 3, 2024

Conversation

lithomas1
Copy link
Contributor

Description

Swap the order of result,expected to expected, result for assert_table_eq too
Fix a few places where result,expected was swapped for assert_column_eq

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@lithomas1 lithomas1 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 30, 2024
@lithomas1 lithomas1 requested a review from a team as a code owner May 30, 2024 17:28
@github-actions github-actions bot added the Python Affects Python cuDF API. label May 30, 2024
@lithomas1 lithomas1 added the pylibcudf Issues specific to the pylibcudf package label May 31, 2024
@vyasr
Copy link
Contributor

vyasr commented Jun 3, 2024

/merge

@rapids-bot rapids-bot bot merged commit 90b3094 into rapidsai:branch-24.08 Jun 3, 2024
71 checks passed
@lithomas1 lithomas1 deleted the pylibcudf-utils-followup branch June 3, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@vyasr vyasr vyasr approved these changes

@brandon-b-miller brandon-b-miller Awaiting requested review from brandon-b-miller brandon-b-miller is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change pylibcudf Issues specific to the pylibcudf package Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lithomas1 @vyasr @mroeschke