Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap cudf::round in pylibcudf #15881

Closed
wants to merge 2 commits into from
Closed

Wrap cudf::round in pylibcudf #15881

wants to merge 2 commits into from

Conversation

wence-
Copy link
Contributor

@wence- wence- commented May 29, 2024

Description

Add round wrapper and migrate classic cython code to use it.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@wence- wence- requested a review from a team as a code owner May 29, 2024 17:32
@github-actions github-actions bot added Python Affects Python cuDF API. CMake CMake build issue labels May 29, 2024
@lithomas1
Copy link
Contributor

overlaps with #15863

@wence-
Copy link
Contributor Author

wence- commented May 29, 2024

closed in favour of #15863

@wence- wence- closed this May 29, 2024
@wence- wence- deleted the wence/fea/pylibcudf-round branch May 30, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galipremsagar galipremsagar Awaiting requested review from galipremsagar galipremsagar is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@charlesbluca charlesbluca Awaiting requested review from charlesbluca charlesbluca is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
CMake CMake build issue Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wence- @lithomas1