Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update interleave lists column for large strings #15877

Merged

Conversation

davidwendt
Copy link
Contributor

Description

Fixes the compute_string_sizes_and_interleave_lists_fn functor to use column_device_view::element<string_view>() method to access string row contents instead of using the strings offsets. This removes the need to add specific offsetalator logic to the logic.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 29, 2024
@davidwendt davidwendt self-assigned this May 29, 2024
@davidwendt davidwendt requested a review from a team as a code owner May 29, 2024 15:18
Copy link
Member

@mhaseeb123 mhaseeb123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 5ce95f0 into rapidsai:branch-24.08 May 30, 2024
76 checks passed
@davidwendt davidwendt deleted the interleave-offsetalator branch May 30, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants