Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix url-decode benchmark to use offsetalator #15871

Merged

Conversation

davidwendt
Copy link
Contributor

Description

Fixes the logic for generating URLs in the url-decoder benchmark to use the offsetalator instead of hardcoding size_type.
This will allow benchmarking with large strings column in the future.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 28, 2024
@davidwendt davidwendt self-assigned this May 28, 2024
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels May 30, 2024
@davidwendt davidwendt marked this pull request as ready for review May 31, 2024 00:18
@davidwendt davidwendt requested a review from a team as a code owner May 31, 2024 00:18
@davidwendt davidwendt requested review from vuule and nvdbaranec May 31, 2024 00:18
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 1354abd into rapidsai:branch-24.08 May 31, 2024
71 of 72 checks passed
@davidwendt davidwendt deleted the url-decode-offsetalator branch May 31, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants