Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use offsetalator in strings shift functor #15870

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Use offsetalator in strings shift functor #15870

merged 1 commit into from
Jun 3, 2024

Conversation

davidwendt
Copy link
Contributor

Description

Replaces hardcoded size_type used for offset values in the shift_chars_fn functor with offsetalator.
Follow on to #15630

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python) improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 28, 2024
@davidwendt davidwendt self-assigned this May 28, 2024
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels May 31, 2024
@davidwendt davidwendt marked this pull request as ready for review May 31, 2024 00:20
@davidwendt davidwendt requested a review from a team as a code owner May 31, 2024 00:20
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit f30ea0a into rapidsai:branch-24.08 Jun 3, 2024
70 of 72 checks passed
@davidwendt davidwendt deleted the shift-fn-offsetalator branch June 3, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmattione-nvidia pmattione-nvidia pmattione-nvidia approved these changes

@PointKernel PointKernel PointKernel approved these changes

@harrism harrism Awaiting requested review from harrism harrism is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change strings strings issues (C++ and Python)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidwendt @PointKernel @pmattione-nvidia