Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Frame.astype return Self instead of a ColumnAccessor #15861

Merged
merged 4 commits into from
Jun 4, 2024

Conversation

mroeschke
Copy link
Contributor

Description

Allows simplification for it's subclasses (IndexFrame.astype, Index.astype)

Also minor cleanups in the equals method

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 24, 2024
@mroeschke mroeschke requested a review from a team as a code owner May 24, 2024 20:52
@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit faf3929 into rapidsai:branch-24.08 Jun 4, 2024
70 checks passed
@mroeschke mroeschke deleted the ref/astype_equals branch June 4, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants