-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add unit test setup for cudf_kafka #15853
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
added
2 - In Progress
Currently a work in progress
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
labels
May 24, 2024
mroeschke
reviewed
May 24, 2024
jameslamb
changed the title
WIP: add unit test setup for cudf_kafka
add unit test setup for cudf_kafka
May 24, 2024
jameslamb
added
3 - Ready for Review
Ready for review by team
and removed
2 - In Progress
Currently a work in progress
labels
May 24, 2024
bdice
approved these changes
May 28, 2024
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3 - Ready for Review
Ready for review by team
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
Python
Affects Python cuDF API.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #15841
Proposes adding a basic unit test setup for
cudf_kafka
.Checklist
Notes for Reviewers
I tried to follow the patterns I saw for
custreamz
anddask_cudf
as closely as possible.If you're wondering why you don't see the
[test]
extra added topyproject.toml
in the diff... it's already there:cudf/python/cudf_kafka/pyproject.toml
Lines 28 to 33 in 8b5ff18