Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unit test setup for cudf_kafka #15853

Merged
merged 9 commits into from
May 29, 2024

Conversation

jameslamb
Copy link
Member

@jameslamb jameslamb commented May 24, 2024

Description

Fixes #15841

Proposes adding a basic unit test setup for cudf_kafka.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Notes for Reviewers

I tried to follow the patterns I saw for custreamz and dask_cudf as closely as possible.

If you're wondering why you don't see the [test] extra added to pyproject.toml in the diff... it's already there:

[project.optional-dependencies]
test = [
"pytest-cov",
"pytest-xdist",
"pytest<8",
] # This list was generated by `rapids-dependency-file-generator`. To make changes, edit ../../dependencies.yaml and run `rapids-dependency-file-generator`.

@jameslamb jameslamb added 2 - In Progress Currently a work in progress improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 24, 2024
@github-actions github-actions bot added Python Affects Python cuDF API. ci labels May 24, 2024
@jameslamb jameslamb changed the title WIP: add unit test setup for cudf_kafka add unit test setup for cudf_kafka May 24, 2024
@jameslamb jameslamb added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels May 24, 2024
@jameslamb jameslamb marked this pull request as ready for review May 24, 2024 20:48
@jameslamb jameslamb requested review from a team as code owners May 24, 2024 20:48
@jameslamb jameslamb requested review from bdice and isVoid May 24, 2024 20:48
@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit afd5522 into rapidsai:branch-24.08 May 29, 2024
70 checks passed
@jameslamb jameslamb deleted the kafka-tests branch May 29, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] cudf_kafka: add unit tests
3 participants