Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement on_bad_lines in json reader #15834

Merged
merged 4 commits into from
May 24, 2024

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented May 23, 2024

Description

Fixes: #15559

This PR implements on_bad_lines in json reader. When on_bad_lines="recover", bad lines are replaced by <NA> values.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar self-assigned this May 23, 2024
@galipremsagar galipremsagar changed the base branch from branch-24.06 to branch-24.08 May 23, 2024 09:56
@github-actions github-actions bot added the Python Affects Python cuDF API. label May 23, 2024
@galipremsagar galipremsagar marked this pull request as ready for review May 24, 2024 19:00
@galipremsagar galipremsagar requested a review from a team as a code owner May 24, 2024 19:00
@galipremsagar galipremsagar changed the title implement on_bad_lines in json reader Implement on_bad_lines in json reader May 24, 2024
@galipremsagar galipremsagar added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change 3 - Ready for Review Ready for review by team labels May 24, 2024
@galipremsagar
Copy link
Contributor Author

@mroeschke This is now ready for review.

@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit d756c37 into rapidsai:branch-24.08 May 24, 2024
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Expose json_recovery_mode in cudf.read_json Python API, and add a column with filenames index
2 participants