-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an option to run cuIO benchmarks with pinned buffers as input #15830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vuule
added
feature request
New feature or request
tests
Unit testing for project
cuIO
cuIO issue
non-breaking
Non-breaking change
labels
May 22, 2024
ttnghia
approved these changes
May 23, 2024
…fea-pinned-bm-io
Parquet reader benchmarks (partial) show clear signal compared to pageable input:
On the other hand, not observing a clear signal with the multithreaded Parquet benchmark, even in the single-threaded cases. Something we'll want to investigate as we look further into multithreaded scaling. |
davidwendt
reviewed
May 29, 2024
…fea-pinned-bm-io
… fea-pinned-bm-io
davidwendt
approved these changes
May 31, 2024
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
5 - Ready to Merge
Testing and reviews complete, ready to merge
cuIO
cuIO issue
feature request
New feature or request
libcudf
Affects libcudf (C++/CUDA) code.
non-breaking
Non-breaking change
tests
Unit testing for project
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
io_type::PINNED_BUFFER
, which allows cuIO benchmarks to use a pinned buffer as an input. The output is still astd::vector
in this case, same as withio_type::HOST_BUFFER
.Also stops the used of
cudf::io::io_type
in benchmarks, to allow benchmark-specific IO types, such as this one.Checklist