Migrate reshape.pxd to pylibcudf #15827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Python
mroeschke
added
improvement
|
This should be green and ready for a look now (tests have been added). |
mroeschke
reviewed
May 23, 2024
Co-authored-by: Matthew Roeschke <[email protected]>
vyasr
approved these changes
May 24, 2024
Comment on lines
+17
to
+18
| arrow_tbl = pa.Table.from_arrays(reshape_data, names=["a", "b"]) | ||
| plc_tbl = plc.interop.from_arrow(arrow_tbl) |
There was a problem hiding this comment.
Might as well pull this out into a fixture too so that it's only done once (especially since you parametrize the tile test below so it'll do this four times).
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
xref #15162
Checklist
Not sure what to do about byte_cast, which appears in the reshape.hpp file but isn't used by cudf-python (only by java and cpp).