Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate divisions='quantile' support in set_index #15804

Merged

Conversation

rjzamora
Copy link
Member

@rjzamora rjzamora commented May 21, 2024

Description

Using set_index(..., divisions='quantile') is not supported by dask-cudf when query-planning is enabled. However, this option doesn't seem to serve a purpose anymore. This PR deprecates the option in general.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@rjzamora rjzamora added 2 - In Progress Currently a work in progress dask Dask issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 21, 2024
@rjzamora rjzamora self-assigned this May 21, 2024
@rjzamora rjzamora requested a review from a team as a code owner May 21, 2024 18:02
@github-actions github-actions bot added the Python Affects Python cuDF API. label May 21, 2024
@rjzamora rjzamora added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 2 - In Progress Currently a work in progress labels May 22, 2024
@rjzamora
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 45dc595 into rapidsai:branch-24.06 May 22, 2024
71 checks passed
@rjzamora rjzamora deleted the deprecate-divisions-quantile branch May 22, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge dask Dask issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants