Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add temporary dask-cudf workaround for categorical sorting #15801

Merged
merged 2 commits into from
May 22, 2024

Conversation

rjzamora
Copy link
Member

Description

Follow up to #15788

Adds a temporary workaround for sorting on categorical columns in 24.06: We convert only the partitioning column to pandas to calculate divisions.

This is related to #11795, but I don't want to "close" that issue until RepartitionQuantiles works with cudf-backed data.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@rjzamora rjzamora added bug Something isn't working 2 - In Progress Currently a work in progress dask Dask issue non-breaking Non-breaking change labels May 21, 2024
@rjzamora rjzamora self-assigned this May 21, 2024
@github-actions github-actions bot added the Python Affects Python cuDF API. label May 21, 2024
@rjzamora rjzamora marked this pull request as ready for review May 21, 2024 15:16
@rjzamora rjzamora requested a review from a team as a code owner May 21, 2024 15:16
@rjzamora rjzamora added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels May 21, 2024
@galipremsagar
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 766fbb7 into rapidsai:branch-24.06 May 22, 2024
70 checks passed
@rjzamora rjzamora deleted the categorical-workaround branch May 22, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working dask Dask issue non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants