Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dask-cudf isin support #15770

Closed
wants to merge 2 commits into from
Closed

Fix dask-cudf isin support #15770

wants to merge 2 commits into from

Conversation

rjzamora
Copy link
Member

Description

Updates as_column to handle an inferred "integer" dtype from an "object" array.
This pattern is currently required for isin support in dask.

Closes #15768

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@rjzamora rjzamora added 2 - In Progress Currently a work in progress dask Dask issue non-breaking Non-breaking change labels May 16, 2024
@rjzamora rjzamora self-assigned this May 16, 2024
@github-actions github-actions bot added the Python Affects Python cuDF API. label May 16, 2024
@rjzamora rjzamora added the bug Something isn't working label May 16, 2024
@rjzamora
Copy link
Member Author

Closing in favor of #15771, since it preserves mixed-dtype protection

@rjzamora rjzamora closed this May 17, 2024
@rjzamora rjzamora deleted the fix-isin branch May 17, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rjzamora rjzamora

Labels
2 - In Progress Currently a work in progress bug Something isn't working dask Dask issue non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] dask-cudf isin errors when passing in a list of values
1 participant
@rjzamora